Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: feature wait before rejecting a withdrawal request #1411

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: feature wait before rejecting a withdrawal request #1411

wants to merge 9 commits into from
+337 −9

Conversation

djordon
Copy link
Collaborator

@djordon djordon commented Feb 21, 2025

Description

Closes #1407

Changes

  • Add in a validation check that looks for "active" withdrawals. These are withdrawals where it's possible that a fork could make the transaction valid in the eyes of the bitcoin network.
  • Made sure that the coordinator did the same "is active" check when selecting requests to reject.

Testing Information

So far this PR has added one test. The comments in it are likely wrong and stuff, and it needs a little polish. I will fix that all up and add more tests.

Checklist:

  • I have performed a self-review of my code

@djordon djordon added sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation. labels Feb 21, 2025
@djordon djordon self-assigned this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteojug matteojug matteojug left review comments

@Jiloc Jiloc Awaiting requested review from Jiloc

@cylewitruk cylewitruk Awaiting requested review from cylewitruk

At least 1 approving review is required to merge this pull request.

Assignees

@djordon djordon

Labels
sbtc signer binary The sBTC Bootstrap Signer. withdrawal The withdrawal sBTC operation.
Projects
sBTC
Status: In Review
Milestone
sBTC: Withdrawal Code Complete
Development

Successfully merging this pull request may close these issues.

[Feature]: Wait before rejecting a withdrawal request
2 participants
@djordon @matteojug