Feat/check pox 2 params

[jcnelson]

This PR adds a config method that will validate the PoX 2 and epoch parameters. Specifically:

• v1_unlock_height must be strictly after the epoch 2.1 start height, and cannot fall on a reward cycle start boundary if it's in the subsequent reward cycle from the epoch 2.1 start.
• If v1_unlock_height falls in the same reward cycle as the epoch 2.1 start height, then the epoch 2.1 start height must be in the reward phase -- ideally, the very first block.

The reasons for this are that the v1_unlock_height value is used to determine which PoX contract to query to determine a reward cycle's reward set. So, pox-2 must be instantiated before the PoX anchor block for its first reward cycle is mined. This also means that v1_unlock_height must not be at the very beginning of a reward cycle -- reward cycles start at the first block, not the zeroth block, of the reward cycle, so the reward cycle of a v1_unlock_height that fell on a sortition height such that sortition_height % reward_cycle_len == 0 would be in the preceding reward cycle.

This PR makes the both the mocknet and Neon nodes panic early if these conditions are not met.

I'm going to see if all integration tests continue to pass with the settings we've given them. But in the mean time, feel free to try this out. This is meant to address #3407.

EDIT: this PR now also fixes #3367.

[wileyj]

shipit

[deantchi]

LGTM

[codecov]

Codecov Report

Merging #3409 (b2d886a) into next (ce61513) will increase coverage by 23.04%.
The diff coverage is 51.71%.

@@             Coverage Diff             @@
##             next    #3409       +/-   ##
===========================================
+ Coverage   28.58%   51.63%   +23.04%     
===========================================
  Files         284      229       -55     
  Lines      260447   121772   -138675     
===========================================
- Hits        74439    62872    -11567     
+ Misses     186008    58900   -127108     

Impacted Files	Coverage Δ
clarity/src/vm/errors.rs	29.68% <ø> (-9.21%)	⬇️
src/chainstate/stacks/db/mod.rs	83.81% <0.00%> (+14.19%)	⬆️
src/clarity_vm/special.rs	22.82% <0.00%> (-24.89%)	⬇️
src/net/mod.rs	43.82% <ø> (+25.59%)	⬆️
testnet/stacks-node/src/tests/epoch_205.rs	12.03% <0.00%> (-55.79%)	⬇️
testnet/stacks-node/src/tests/epoch_21.rs	0.00% <0.00%> (-68.03%)	⬇️
testnet/stacks-node/src/tests/integrations.rs	0.00% <0.00%> (-41.33%)	⬇️
testnet/stacks-node/src/tests/mod.rs	44.93% <18.18%> (-9.77%)	⬇️
src/burnchains/db.rs	71.35% <23.52%> (-1.42%)	⬇️
src/net/relay.rs	60.55% <37.03%> (+38.77%)	⬆️
... and 251 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jcnelson]

This PR now addresses #3367. It does so by pushing the boot receipts immediately after instantiating the chainstate, but before any bitcoin block header synchronization happens. To do this, it pushes the events attached to the true genesis block -- the one with height 0.

[zone117x]

@jcnelson can you add a check to one of the TestEventObserver tests to ensure the pox-2 tx is emitted? I'm now only seeing the costs-3 tx in the epoch2.1 /new_block payload. I've tested with several different block height toml configurations, and with & without performing a stacks-node restart.

The pox-2 contract does exist when querying the /v2/data_var/ST000000000000000000002AMW42H/pox-2/configured endpoint, and it can be called from contract-call txs. It's just not showing up in the event stream.

[jcnelson]

@zone117x Try now. There was a bug in the epoch initialization code in which it didn't return the tx receipts for both costs-3 and pox-2.

[zone117x]

Thanks for the quick fix @jcnelson, the pox-2 tx is being emitted now. I'm working on ingesting the new "block 0" data to ensure there are no breaking changes and will get back to you here when done.

[zone117x]

Tested the following changes from this PR and looks good:

• The toml config validation behavior is working as expected, e.g. early exit when invalid heights are configured, solves [Stacks 2.1] Miner error for epoch start_height and pox_2_activation config values #3407
• The API has a PR that consumes the new the "block 0" changes, solves [Stacks 2.1] Epoch 2.0 boot data is not emitted to event-observers #3367
• The pox-2 and cost-3 tx receipts from the epoch 2.1 block are all emitted consistently
• The node no longer panics when stacking to both pox-1 and pox-2 during period 2a, instead the second stacking tx is rejected, solves [Stacks 2.1] Node panics when stacking to pox-2 while already locked to pox-1 #3423

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.