Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing functions to trait #5512

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

csgui
Copy link

@csgui csgui commented Nov 27, 2024

No description provided.

@csgui csgui requested a review from a team as a code owner November 27, 2024 12:19
@csgui csgui requested a review from hugocaillard November 27, 2024 12:19
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it target #5509?

@csgui
Copy link
Author

csgui commented Nov 27, 2024

@hugocaillard I don't think so. #5509 already added those functions to the trait.

Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csgui csgui merged commit 939c650 into feat/clarity-wasm-develop Nov 27, 2024
1 check passed
@csgui csgui deleted the chore/add_missing_functions_to_trait branch November 27, 2024 15:15
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants