Fix/5502 #5544
Merged
Fix/5502 #5544
+87
−556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o handle (now legacy) cases where the PoX anchor block does not arrive in order (or at all)
|
Wow so much red! Noice! |
jferrant
previously approved these changes
Dec 10, 2024
obycode
previously approved these changes
Dec 16, 2024
jferrant
previously approved these changes
Dec 17, 2024
obycode
approved these changes
Dec 18, 2024
jferrant
approved these changes
Dec 18, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5502. I have confirmed it with a genesis sync. It works by preventing the chains coordinator from advancing the sortition view until the corresponding PoX anchor block is found. This is now an unconditional requirement, since we know for a fact that all reward cycles have a PoX anchor block (and as of Nakamoto, _msut- have one). It paves the way for removing the entirety of the affirmation map subsystem.