feat: redesign nonce cache #5602
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This redesign uses a proper LRU cache and is more careful about flushing the cache more efficiently.
jbencin
reviewed
Dec 20, 2024
stackslib/src/core/nonce_cache.rs
Outdated
| clarity_instance | ||
| .begin_test_genesis_block( | ||
| &StacksBlockId::sentinel(), | ||
| &StacksBlockId([0 as u8; 32]), |
There was a problem hiding this comment.
I know you didn't write this and just moved this file, but the proper way to do this is
Suggested change
| &StacksBlockId([0 as u8; 32]), | |
| &StacksBlockId([0u8; 32]), |
There was a problem hiding this comment.
Updated in e4f0b7b.
jbencin
reviewed
Dec 20, 2024
stacks-common/src/util/lru_cache.rs
Outdated
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| use std::collections::HashMap; |
jbencin
reviewed
Dec 20, 2024
obycode
commented
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #5599 except built against develop.
This redesign uses a proper LRU cache and is more careful about flushing the cache more efficiently.