chore: Apply new lints in Clippy 1.78 (version 2) #5643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbencin
force-pushed
the
chore/clippy-1.78-new-lints
branch
from
7c3528b to
b7c82ca
Compare
jferrant
approved these changes
Jan 3, 2025
obycode
approved these changes
Jan 3, 2025
Merged
via the queue into
stacks-network:develop
with commit Jan 4, 2025
2e8ac08
166 of 173 checks passed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply the following lints introduced in Clippy 1.78:
unnecessary_get_then_check: Replace.get().is_some()withcontains_key()assigning_clones: Use possibly more efficientclone_from()instead ofclone()where availableto_string_trait_impl: Implementstd::fmt::Displayinstead ofToStringincompatible_msrv: Use correct MSRV in Cargo.tomlThis is a newer version of #4780 made by re-applying changes on latest
developApplicable issues