Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy::needless_borrow throughout stackslib #5651

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix clippy::needless_borrow throughout stackslib #5651

wants to merge 4 commits into from
+1,537 −1,615

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Jan 4, 2025

No description provided.

@jferrant jferrant requested a review from a team as a code owner January 4, 2025 01:26
jbencin
jbencin reviewed Jan 6, 2025
View reviewed changes
stackslib/src/net/p2p.rs Outdated Show resolved Hide resolved
jbencin
jbencin reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@jbencin jbencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge PR for a single lint. I remember one of the first things I noticed about this repo was how many unnecessary refs and &s there were

I made some comments about code this PR touched but you didn't write, I figure it's a good opportunity to clean these things up

obycode
obycode previously approved these changes Jan 8, 2025
View reviewed changes
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
c3ccfb2 
… into fix/clippy-ci-stacks-lib-needless-borrow
@jferrant
CRC: cleanup
e45112a 
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant requested review from jbencin and obycode January 9, 2025 16:14
@jferrant jferrant enabled auto-merge January 9, 2025 19:59
@jferrant jferrant disabled auto-merge January 9, 2025 20:00
@jferrant jferrant enabled auto-merge January 13, 2025 22:04
@jferrant jferrant disabled auto-merge January 13, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbencin jbencin jbencin approved these changes

@obycode obycode obycode approved these changes

@jcnelson jcnelson Awaiting requested review from jcnelson

@hstove hstove Awaiting requested review from hstove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jferrant @obycode @jbencin