Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a reengineering of #5484 based on feedbacks from both the initial code review and nakamoto meetings.
In this first draft it just covers the infrastructure for adding a new "txindex" (boolean) option in the node config and deprecation of the old STACKS_TRANSACTION_LOG environment variable.
This option injects into the nakamoto coordinator and adds a parameter to NakamotoChainState::process_next_nakamoto_block enabling/disabling the record of a transaction.
Note that enabling both txindex and STACKS_TRANSACTION_LOG will trigger an error on startup prevending the system to enable both.
Once this first draft is approved i will add back the rpc endpoints features (that should be way more simple now)
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml