Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/txindex #5661

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Feat/txindex #5661

wants to merge 3 commits into from

Conversation

rdeioris
Copy link
Contributor

@rdeioris rdeioris commented Jan 6, 2025

Description

This is a reengineering of #5484 based on feedbacks from both the initial code review and nakamoto meetings.

In this first draft it just covers the infrastructure for adding a new "txindex" (boolean) option in the node config and deprecation of the old STACKS_TRANSACTION_LOG environment variable.

This option injects into the nakamoto coordinator and adds a parameter to NakamotoChainState::process_next_nakamoto_block enabling/disabling the record of a transaction.

Note that enabling both txindex and STACKS_TRANSACTION_LOG will trigger an error on startup prevending the system to enable both.

Once this first draft is approved i will add back the rpc endpoints features (that should be way more simple now)

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@rdeioris rdeioris mentioned this pull request Jan 7, 2025
5 tasks
@aldur aldur requested a review from jcnelson January 8, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant