chore: Apply Clippy lint needless_collect

[jbencin]

Description

Apply Clippy lint needless_collect. This finds places where iterators can be used directly, without having to call collect() and trigger a heap allocation

[obycode]

LGTM

[jbencin]

Fixed unit tests by adding missing parenthesis. I'm surprised Rust didn't complain about this. Changed:

if !event_ids.count() == 0 && !other_event_ids.count() == 0

to

if !(event_ids.count() == 0) && !(other_event_ids.count() == 0)

[jferrant]

Fixed unit tests by adding missing parenthesis. I'm surprised Rust didn't complain about this. Changed:

if !event_ids.count() == 0 && !other_event_ids.count() == 0

to

if !(event_ids.count() == 0) && !(other_event_ids.count() == 0)

Don't need to change it. But couldn't you just do event_ids.count() != 0 and other_event_ids.count() != 0?

[jbencin]

But couldn't you just do event_ids.count() != 0 and other_event_ids.count() != 0?

I suppose I could have. Maybe Clippy will fix this in a future PR