fix: prevent flaky check for responses by only checking threshold #5719
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferrant
approved these changes
Jan 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (hopeful) improvement to potential flakiness that is described in #5718. This does not completely eliminate that test-only race condition, but it hopefully fixes at least one instance where this could happen.
Basically, this PR changes the expectation from requiring all signers to submit rejections to only needing 30% of them to reject (and in this flaky scenario, it failed because only 4/5 rejected instead of 5/5)