feat: reduce default block_rejection_timeout_steps
#6013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wileyj
previously approved these changes
Apr 16, 2025
|
Looks like this change may require some tweaks to some tests. I will come back to those. |
In addition to waiting for the last block it mined to be processed, now the miner will also wait to be unblocked. This ensures that the miner does not start mining before it is unblocked by the chains coordinator thread. This solves flakiness in `tests::signer::v0::verify_mempool_caches`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6013 +/- ##
===========================================
- Coverage 84.10% 83.55% -0.55%
===========================================
Files 528 523 -5
Lines 385675 384564 -1111
Branches 323 0 -323
===========================================
- Hits 324355 321340 -3015
- Misses 61312 63224 +1912
+ Partials 8 0 -8
... and 50 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
kantai
approved these changes
Apr 17, 2025
wileyj
approved these changes
Apr 17, 2025
github-project-automation
bot
moved this from Status: In Review
to Status: 💻 In Progress
in Stacks Core Eng
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
stacks-network:develop
with commit Apr 18, 2025
535cef0
203 of 205 checks passed
github-project-automation
bot
moved this from Status: 💻 In Progress
to Status: ✅ Done
in Stacks Core Eng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.