SIP-011 The buy-in-ustx Standard for non-custodial Marketplace traits #119
Conversation
There was a problem hiding this comment.
This is looking very good @314159265359879 . Here's an initial pass, focusing mostly on SIP document style
There was a problem hiding this comment.
Style nit: can you format this file so it doesn't exceed 100 characters per line?
| License: CC0-1.0 | ||
|
|
||
| Sign-off: Brice Dobry <[email protected]>, Technical Consideration Advisory Boards (CAB) Chair | ||
| Sign-off: Jude Nelson <[email protected]>, Technical Steering Committee Chair |
|
|
||
| Type: Standard | ||
|
|
||
| Status: draft |
There was a problem hiding this comment.
| Status: draft | |
| Status: Draft |
|
|
||
| This standard aims to formalize a the commonly used traits to offer fungible or non-fungible tokens for sale, at a certain price in STX, from a non-custodial wallet. | ||
|
|
||
| # License and Copyright |
There was a problem hiding this comment.
| # License and Copyright | |
| # Copyright |
|
|
||
| The `marketplace trait` can be implemented as part of the asset contract (usually not recommended) or as an independent contract. | ||
|
|
||
| The marketplace functions have been used since the first Megapont contract was deployed to mainnet in October 2022 and have since become the pseudo standard for non-custodial listing of assets on the Stacks Blockchain. Having this ratified as an official standard can help further adoption of the standard. [(1)](https://) [(2)](https://github.com/stacksgov/sips/issues/92#issuecomment-1360144565). A more generalized trait is also recommended to replace this one in the future. A standard that will be compatible with SIP013 tokens too. And one that will allow buying with SIP013 or SIP010 tokens aswell as STX. |
|
|
||
| # Backwards Compatibility | ||
|
|
||
| Not applicable |
There was a problem hiding this comment.
Could you mention why? Perhaps you already touched a bit on this on earlier sections but you could describe how NFT contracts that don't conform to this new trait could continue to be traded or how they would interact with contracts that do implement the trait
|
|
||
| # Activation | ||
|
|
||
| This SIP is considered activated after no objections within the community before Bitcoin tip #800,000. There are already over 20 contracts deployed to mainnet that have implemented this standard. The aim with this document is to formalize it through this SIP. |
There was a problem hiding this comment.
I think you should provide a set number of minimum contracts that have to implement the trait for activation. Could be that the number is already met, but I think having an objective threshold is a good idea.
| Instead of unified trait to allow the use of SIP010, SIP009 and SIP013 tokens for purchase have two traits one for SIP009 and SIP010 and the other for SIP013. This would eleviate the need for a uint that is ignored when using SIP009 and SIP010 but is required for using SIP013 tokens as one would have to define both a token identifier and an amount. | ||
|
|
||
|
|
||
| # Reference Implementations list-in-ustx |
There was a problem hiding this comment.
| # Reference Implementations list-in-ustx | |
| # Reference Implementations |
|
|
||
| ## Source code | ||
|
|
||
| # Sources |
| # Alternative for consideration | ||
| Instead of unified trait to allow the use of SIP010, SIP009 and SIP013 tokens for purchase have two traits one for SIP009 and SIP010 and the other for SIP013. This would eleviate the need for a uint that is ignored when using SIP009 and SIP010 but is required for using SIP013 tokens as one would have to define both a token identifier and an amount. |
There was a problem hiding this comment.
This paragraph should go in the Related Work section
|
It seems unnatural for me to require a commission trait for a non-custodial market function. Commission trait should be optional. As a holder of an NFT with these functions, I can list or unlist without requiring a marketplace. As an NFT buyer, I should be able to buy without requiring a marketplace. Ie. I can choose to list via some marketplace, and they may add a commission. But I can also just list my NFT for sale on my own, and choose to sell directly to another person. Also, IMHO, at the risk of devolving into a semantic discussion, I feel like the term "global marketplace" is incorrect. In reality, the listing spec doesn't even require creating an event, so all we're doing here is setting state for an individual nft to make it available for purchase. |
SIP-011 The buy-in-ustx Standard for non-custodial Marketplace traits
As discussed in #92 (comment) here is the draft for the buy-in-ustx Marketplace standard which is already widely used within the Stacks ecosystem.