SIP-033 The Generalized Standard for non-custodial Marketplace traits #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AcrossfireX
reviewed
Apr 11, 2023
|
|
||
| The `marketplace trait` can be implemented as part of the asset contract (usually not recommended) or as an independent contract. | ||
|
|
||
| The marketplace functions have been used since the first Megapont contract was deployed to mainnet in October 2022 and have since become the pseudo standard for non-custodial listing of assets on the Stacks Blockchain. Having an this official standard ratified can help further adoption of the standard. [(1)](https://) [(2)](https://github.com/stacksgov/sips/issues/92#issuecomment-1360144565) |
There was a problem hiding this comment.
Link 1 is broken - should remove or replace with appropriate reference
AcrossfireX
reviewed
Apr 11, 2023
|
|
||
| Sign-off: Brice Dobry <[email protected]>, Technical Consideration Advisory Boards (CAB) Chair | ||
| Sign-off: Jude Nelson <[email protected]>, Technical Steering Committee Chair | ||
|
|
There was a problem hiding this comment.
Should add Traits field.
Traits: marketplace-functions and commission-functions
314159265359879
changed the title
|
Changed the name to SIP-033 to prevent confusion with the stack-extend bug fix SIP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a very early draft PR of what a more generalized standard for non-custodial marketplace traits could look like.
Before this can be send to the CAB's I would suggest this be thoroughly reviewed edited by clarity experts and tested by one or more of the existing marketplaces on Stacks for tradeables such as gamma.io or tradeport.xyz.
Where SIP011 is simple and allows listing of NFT's only in microSTX (STX). A standard already widely used.
This standard is envisioned for listing of any Standard token (SIP009 (NFT), SIP010 (FT) and SIP013 (SFT)) and setting a selling price in any of those standard tokens too. buy-in-token rather than "buy-in-ustx".