Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Items through external test data #2

Closed
m-mohr opened this issue Sep 30, 2022 · 5 comments
Closed

Add tests for Items through external test data #2

m-mohr opened this issue Sep 30, 2022 · 5 comments
Labels

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Sep 30, 2022

Test against two online files

Run tests without COGs for push/PR and with COGs for releases.

m-mohr added a commit that referenced this issue Sep 30, 2022
m-mohr added a commit that referenced this issue Sep 30, 2022
m-mohr added a commit that referenced this issue Oct 2, 2022
m-mohr added a commit that referenced this issue Oct 2, 2022
@gadomski
Copy link
Contributor

I've added two external data urls in this branch: https://github.com/stactools-packages/esa-cci-lc/tree/add-external-data. However, when I tried to download, it eventually timed out. We may have to have manual external data instructions instead rather than an automatic process, since these files as so big.

Alternatively, we could try to subset the netcdfs?

@m-mohr
Copy link
Collaborator Author

m-mohr commented Oct 14, 2022

Hmm, or extend the timeout? I assume in CI it would actually be faster because we are not limited by slow home internet connections.

Manual external instructions would essentially mean no CI for tests, which is unfortunate.

Unfortunately, I did not manage to subset the files yet.

I also faced some questions: stac-utils/stactools#364

By the way, I always worked on the pure nc files, not on archive files. This is due to the fact that you can download multiple files either as zip or tar.gz from CDS, so I'd think extraction needs to happen beforehand to be explicit about which file(s) to convert.

@m-mohr m-mohr added the help wanted Extra attention is needed label Oct 24, 2022
@m-mohr
Copy link
Collaborator Author

m-mohr commented Oct 31, 2022

I've merged the tests to the main branch. I've added instructions how to download the tests files and where to place them. If files are missing the tests are skipped. Unfortunately, I did not have the time to make the external download for tests work.

Details: https://github.com/stactools-packages/esa-cci-lc#tests

@m-mohr
Copy link
Collaborator Author

m-mohr commented Oct 31, 2022

Further implementing external test data handling through stactools in the add-external-data branch did not work due to the following upstream issues:

@m-mohr m-mohr changed the title Add tests Add tests for Items through external test data Oct 31, 2022
@m-mohr m-mohr added upstream and removed help wanted Extra attention is needed labels Oct 31, 2022
@pjhartzell
Copy link
Contributor

Closed by #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants