Split into COG and NetCDF sub-packages #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new tests, fill out function docstrings
The version extension is primarily for STAC Item or Collection versions, not for asset generation methodology versions. The version is now contained in an extra field on the netcdf Items, which is consistent with the COG Items.
All class lists are included in the collection item_assets
The class list in the Collection summaries and in Item properties was ambiguous as to the applicable NetCDF variable. Additional, unlisted classes also exist in the data that are not part of the class list.
Fixes an orjson complaint
This reverts commit a7d4147.
gadomski
requested changes
Dec 20, 2022
gadomski
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
#2
Description:
This is a major reorganization that splits the package into two sub-packages:
netcdf: Collection and Items describing the source NetCDF data files.cog: Creates tiled COGs from the source NetCDF data files and Items describing each tile of COG data. The Items can optionally contain aderived_fromlink that points to a STAC Item describing the source NetCDF (e.g., an Item created by thenetcdfsub-package).PR checklist:
scripts/format).scripts/lint).scripts/test).