apply more suggestions from review

stactools-packages · Nov 19, 2024 · 538ac16 · 538ac16
1 parent d403377
commit 538ac16
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 5 deletions.
diff --git a/src/stactools/glad_glclu2020/commands.py b/src/stactools/glad_glclu2020/commands.py
@@ -1,4 +1,5 @@
 import logging
+import warnings
 from typing import Optional
 
 import click
@@ -70,6 +71,15 @@ def create_collection_command(
             if collection_type == "annual"
             else CollectionIDs.GLAD_GLCLU2020_CHANGE
         )
+
+        if not (sample_asset_href or media_type):
+            warnings.warn(
+                "No sample_asset_href or media_type provided. "
+                f"Defaulting to {MediaType.GEOTIFF} media type.",
+                category=UserWarning,
+            )
+            media_type = MediaType.GEOTIFF.value
+
         media_type_enum = MediaType(media_type) if media_type else None
 
         collection = stac.create_collection(

diff --git a/src/stactools/glad_glclu2020/metadata.py b/src/stactools/glad_glclu2020/metadata.py
@@ -40,6 +40,7 @@
 
 COLLECTION_START_DATETIME = datetime(2000, 1, 1, tzinfo=timezone.utc)
 COLLECTION_END_DATETIME = datetime(2020, 12, 31, 23, 59, 59, tzinfo=timezone.utc)
+COLLECTION_BBOX = (-180.0, -60.0, 180.0, 80.0)
 
 DEFAULT_HREF_FORMAT = "https://storage.googleapis.com/earthenginepartners-hansen/GLCLU2000-2020/v2/{year}/{loc}.tif"
 
@@ -225,7 +226,7 @@ def build_collection(
             title=self.title,
             description=self.description,
             extent=Extent(
-                SpatialExtent([[-180.0, 80.0, 180.0, -80.0]]),
+                SpatialExtent([list(COLLECTION_BBOX)]),
                 TemporalExtent(
                     [
                         [
@@ -255,8 +256,8 @@ def build_collection(
                     href=(
                         "https://glad.umd.edu/sites/default/files/styles/projects/public/datasets_glulc.jpg?itok=bxS-HPMi"
                     ),
-                    media_type=MediaType.PNG,
-                    title=self.title,
+                    media_type=MediaType.JPEG,
+                    title="Thumbnail",
                     roles=["thumbnail"],
                 )
             },
@@ -282,13 +283,13 @@ def build_collection(
             Link(
                 rel=RelType.LICENSE,
                 target="https://creativecommons.org/licenses/by/4.0/",
-                media_type="text/html",
+                media_type=MediaType.HTML,
                 title="CC-BY-4.0 license",
             ),
             Link(
                 rel="documentation",
                 target=COLLECTION_HOMEPAGE,
-                media_type="text/html",
+                media_type=MediaType.HTML,
                 title="GLAD GLCLU Access Page",
             ),
             Link(

diff --git a/tests/test_commands.py b/tests/test_commands.py
@@ -117,3 +117,20 @@ def test_create_item(
     item = Item.from_file(path)
     assert item.assets[ASSET_NAME].media_type == media_type
     item.validate()
+
+
+def test_create_collection_no_media_type_or_sample(tmp_path: Path) -> None:
+    """Test warning if no media_type or sample_asset_href provided"""
+    path = str(tmp_path / "collection.json")
+    runner = CliRunner()
+    with pytest.warns(UserWarning, match="No sample_asset_href or media_type provided"):
+        result = runner.invoke(
+            command,
+            [
+                "create-collection",
+                "--type",
+                "annual",
+                path,
+            ],
+        )
+    assert result.exit_code == 0, "\n{}".format(result.output)