Sd utilize #214
bharath-123Annotations
10 errors and 4 warnings
|
build:
stader-cli/node/status.go#L119
string `eth` has 4 occurrences, make it a constant (goconst)
|
|
build:
stader-lib/socializing-pool/rewards.go#L26
paramTypeCombine: func(sp *stader.SocializingPoolContractManager, index []*big.Int, amountSd []*big.Int, amountEth []*big.Int, merkleProof [][][32]byte, opts *bind.TransactOpts) (stader.GasInfo, error) could be replaced with func(sp *stader.SocializingPoolContractManager, index, amountSd, amountEth []*big.Int, merkleProof [][][32]byte, opts *bind.TransactOpts) (stader.GasInfo, error) (gocritic)
|
|
build:
stader-lib/socializing-pool/rewards.go#L30
paramTypeCombine: func(sp *stader.SocializingPoolContractManager, index []*big.Int, amountSd []*big.Int, amountEth []*big.Int, merkleProof [][][32]byte, opts *bind.TransactOpts) (*types.Transaction, error) could be replaced with func(sp *stader.SocializingPoolContractManager, index, amountSd, amountEth []*big.Int, merkleProof [][][32]byte, opts *bind.TransactOpts) (*types.Transaction, error) (gocritic)
|
|
build:
stader-lib/utils/eth/units.go#L36
unnamedResult: consider giving a name to these results (gocritic)
|
|
build:
stader-cli/node/claim-sp-rewards.go#L184
elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
|
|
build:
stader/api/validator/deposit.go#L107
cyclomatic complexity 32 of func `canNodeDeposit` is high (> 30) (gocyclo)
|
|
build:
stader-lib/utils/sd/sd.go#L19
func `almostEqual` is unused (unused)
|
|
build:
stader-cli/node/utilize-sd.go#L147
unnecessary leading newline (whitespace)
|
|
build:
stader-lib/sdutility/sd-utility.go#L22
assignments should only be cuddled with other assignments (wsl)
|
|
build:
stader-lib/sdutility/sd-utility.go#L23
only one cuddle assignment allowed before if statement (wsl)
|
|
build:
stader-lib/node/validator.go#L22
var-naming: func parameter referralId should be referralID (revive)
|
|
build:
stader-lib/node/validator.go#L42
var-naming: func parameter referralId should be referralID (revive)
|
|
build:
stader/api/node/utility-sd.go#L42
var-naming: var operatorId should be operatorID (revive)
|
|
build:
stader/api/node/claim-rewards.go#L110
var-naming: var operatorId should be operatorID (revive)
|