Merge pull request #186 from stader-labs/node-diver-metrics #283
batphonghanAnnotations
10 errors and 11 warnings
|
build:
shared/services/config/mev-boost-config.go#L281
Error return value is not checked (errcheck)
|
|
build:
shared/services/config/mev-boost-config.go#L299
Error return value is not checked (errcheck)
|
|
build:
shared/services/config/mev-boost-config.go#L315
Error return value is not checked (errcheck)
|
|
build:
shared/services/config/stader-config.go#L486
Error return value of `cfg.applyAllDefaults` is not checked (errcheck)
|
|
build:
shared/services/stader/client.go#L93
Error return value of `ip4Consensus.UseIPProtocol` is not checked (errcheck)
|
|
build:
shared/services/stader/client.go#L100
Error return value of `ip6Consensus.UseIPProtocol` is not checked (errcheck)
|
|
build:
shared/services/stader/client.go#L493
Error return value of `c.migrateCcSelection` is not checked (errcheck)
|
|
build:
stader-cli/service/service.go#L651
Error return value of `staderClient.SaveConfig` is not checked (errcheck)
|
|
build:
stader/guardian/metrics-exporter.go#L91
Error return value of `w.Write` is not checked (errcheck)
|
|
build:
shared/utils/hex/hex.go#L28
string `0x` has 3 occurrences, make it a constant (goconst)
|
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
build:
shared/utils/arr-utils/arr.go#L1
var-naming: don't use an underscore in package name (revive)
|
|
build:
shared/types/config/types.go#L124
var-naming: don't use underscores in Go names; const MevSelectionMode_Unknow should be MevSelectionModeUnknow (revive)
|
|
build:
shared/types/config/types.go#L125
var-naming: don't use underscores in Go names; const MevSelectionMode_Profile should be MevSelectionModeProfile (revive)
|
|
build:
shared/types/config/types.go#L126
var-naming: don't use underscores in Go names; const MevSelectionMode_Relay should be MevSelectionModeRelay (revive)
|
|
build:
shared/types/config/types.go#L131
var-naming: don't use underscores in Go names; const NimbusPruningMode_Archive should be NimbusPruningModeArchive (revive)
|
|
build:
shared/types/config/types.go#L132
var-naming: don't use underscores in Go names; const NimbusPruningMode_Prune should be NimbusPruningModePrune (revive)
|
|
build:
shared/utils/string-utils/str-convs.go#L1
var-naming: don't use an underscore in package name (revive)
|
|
build:
shared/utils/sys/cpu-flags.go#L30
var-naming: func GetMissingModernCpuFeatures should be GetMissingModernCPUFeatures (revive)
|
|
build:
stader-cli/wallet/bip39/mnemonic-validator.go#L70
error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
|
|
build:
stader-lib/types/validator.go#L14
var-naming: struct field OperatorId should be OperatorID (revive)
|