Merge branch Stg into Main (#612)

* Merge branch Dev into Stg (#611) * fix(SNW-183): Adjust title in Hero DoubleColumnImage component (#610)
stakeordie · May 19, 2023 · 9974176 · 9974176
1 parent d748128
commit 9974176
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 14 deletions.
diff --git a/src/components/dynamic/heros/DoubleColumnImage.vue b/src/components/dynamic/heros/DoubleColumnImage.vue
@@ -1,6 +1,6 @@
 <template>
-  <column>
-    <block>
+  <Column>
+    <Block>
       <section
         class="double-column-image-hero"
         :class="[imagePosition, paddingTop, paddingBottom]"
@@ -38,8 +38,8 @@
           <DynamicButtons :buttons="buttons" :position="buttons_position" />
         </div>
       </section>
-    </block>
-  </column>
+    </Block>
+  </Column>
 </template>
 
 <script>
@@ -48,13 +48,15 @@ import DynamicButtons from "@/components/dynamic/basic/DynamicButtons.vue";
 import DynamicCustomTitle from "@/components/dynamic/basic/DynamicCustomTitle.vue";
 import DynamicEyebrowTitle from "@/components/dynamic/basic/DynamicEyebrowTitle.vue";
 import DynamicBody from "@/components/dynamic/basic/DynamicBody.vue";
+import DynamicTitle from "@/components/dynamic/basic/DynamicTitle.vue";
 
 export default {
   components: {
     DynamicButtons,
     DynamicEyebrowTitle,
     DynamicCustomTitle,
     DynamicBody,
+    DynamicTitle,
   },
   props: {
     image: {

diff --git a/src/components/dynamic/heros/LearnHeader.vue b/src/components/dynamic/heros/LearnHeader.vue
@@ -1,8 +1,14 @@
 <template>
   <div class="learn-header">
-    <p class="learn-header__subtitle">{{ eyebrow_text }}</p>
-    <h1 class="learn-header__title">{{ title }}</h1>
-    <p class="learn-header__about-text">{{ subtitle }}</p>
+    <p class="learn-header__subtitle">
+      {{ eyebrow_text }}
+    </p>
+    <h1 class="learn-header__title">
+      {{ title }}
+    </h1>
+    <p class="learn-header__about-text">
+      {{ subtitle }}
+    </p>
     <ResponsiveImage
       v-if="background_image"
       classes="learn-header__image"
@@ -15,19 +21,19 @@
 <script>
 export default {
   props: {
-    eyebrow_text: String,
-    title: String,
-    subtitle: String,
-    background_image: Object
+    eyebrow_text: { type: String, required: true },
+    title: { type: String, required: true },
+    subtitle: { type: String, required: true },
+    background_image: { type: Object, required: false, default: null },
   },
   computed: {
     widthArticleClass() {
       return {
         "text-column-single--narrow": this.width && this.width === "narrow",
         "text-column-single--standard": this.width && this.width === "standard",
-        "text-column-single--wide": this.width && this.width === "wide"
+        "text-column-single--wide": this.width && this.width === "wide",
       };
-    }
-  }
+    },
+  },
 };
 </script>