@stalniy fix: pre-builds everything to prevent types issues in co-dep…

…endent packages (#854)
stalniy · Nov 21, 2023 · 37b0f01 · 37b0f01
1 parent fa23801
commit 37b0f01
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -37,6 +37,8 @@ jobs:
             ${{ runner.os }}-
       - name: Install dependencies
         run: pnpm install
+      - name: Build
+        run: pnpm run -r build
       - name: Release
         env:
           GH_TOKEN: ${{ secrets.RELEASE_GITHUB_TOKEN }}
@@ -48,8 +50,8 @@ jobs:
           fi
 
           changed_paths="$(gh pr view --json files --jq '.files.[].path' "${{ github.event.pull_request.number }}" | cut -d / -f 1,2 | uniq)";
-          ./packages/dx/bin/release-packages.sh "$changed_paths";
+          released_packages=$(./packages/dx/bin/release-packages.sh "$changed_paths");
 
-          if [ "${{github.event.pull_request.number}}" != "" ]; then
-              gh pr comment "${{ github.event.pull_request.number }}" --body "🚀 Released in ${released_packages[@]}"
+          if [[ "${{github.event.pull_request.number}}" != "" && "$released_packages" != "" ]]; then
+            gh pr comment "${{ github.event.pull_request.number }}" --body "🚀 Released in ${released_packages}"
           fi
diff --git a/packages/dx/bin/release-packages.sh b/packages/dx/bin/release-packages.sh
@@ -38,3 +38,4 @@ for path in $changed_packages; do
 done
 
 echo "🚀 Released in ${released_packages[@]}" >> $GITHUB_STEP_SUMMARY
+echo "${released_packages[@]}"
Original file line number	Diff line number	Diff line change
Expand Up		@@ -38,3 +38,4 @@ for path in $changed_packages; do
		done

		echo "🚀 Released in ${released_packages[@]}" >> $GITHUB_STEP_SUMMARY
		echo "${released_packages[@]}"