chore: complexity

stalniy · Sep 19, 2024 · 98028b0 · 98028b0
1 parent 02793b3
commit 98028b0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/casl-ability/spec/error.spec.ts b/packages/casl-ability/spec/error.spec.ts
@@ -24,7 +24,7 @@ describe('`ForbiddenError` class', () => {
 
     it('does not produce error on forbidden action when inverted', () => {
       const { error } = setup()
-      expect(error.unlessCannot('read', 'Post')).toBeUndefined()
+      expect(error.unlessCannot('archive', 'Post')).toBeUndefined()
     })
 
     it('produces an error on allowed action when inverted', () => {

diff --git a/packages/casl-ability/src/ForbiddenError.ts b/packages/casl-ability/src/ForbiddenError.ts
@@ -56,9 +56,9 @@ export class ForbiddenError<T extends AnyAbility> extends NativeError {
   ): this | undefined {
     const rule = this.ability.relevantRuleFor(action, subject, field);
 
-    const isRuleInverted = rule?.inverted ?? false;
-
-    if (inverted === isRuleInverted) {
+    if (inverted && (!rule || rule.inverted)) {
+      return;
+    } else if (!inverted && rule && !rule.inverted) {
       return;
     }