Allow arrow functions for ability factory arguments to AbilityBuilder (…

…#982)
stalniy · Oct 18, 2024 · ee01fce · ee01fce
1 parent f8e594a
commit ee01fce
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/casl-ability/spec/builder.spec.js b/packages/casl-ability/spec/builder.spec.js
@@ -114,6 +114,17 @@ describe('AbilityBuilder', () => {
     expect(factory).to.have.been.called.with(rules, options)
   })
 
+  it('can create Ability instance from a factory arrow function', () => {
+    const factorySpy = spy()
+    const factory = (...args) => factorySpy(...args)
+    const { can, build, rules } = new AbilityBuilder(factory)
+    const options = {}
+    can('read', 'Post')
+    build(options)
+
+    expect(factorySpy).to.have.been.called.with(rules, options)
+  })
+
   describe('defineAbility', () => {
     it('defines `Ability` instance using DSL', () => {
       const ability = defineAbility((can, cannot) => {

diff --git a/packages/casl-ability/src/AbilityBuilder.ts b/packages/casl-ability/src/AbilityBuilder.ts
@@ -8,7 +8,7 @@ import {
 } from './types';
 
 function isAbilityClass(factory: AbilityFactory<any>): factory is AnyClass {
-  return typeof factory.prototype.possibleRulesFor === 'function';
+  return factory.prototype !== undefined && typeof factory.prototype.possibleRulesFor === 'function';
 }
 
 class RuleBuilder<T extends AnyAbility> {