Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strongly type 'rulesToQuery' return based on return from 'convert' param #876

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

jarpoole
Copy link
Contributor

Fixes #875

Backwards compatibility should be maintained because:

  1. Any consumer explicitly importing and specifying T in RuleToQueryConverter<T> can continue to do so because the new generic param has a default
  2. Likewise for consumers choosing to explicitly specify T in rulesToQuery<T>

@jarpoole
Copy link
Contributor Author

@stalniy not quite sure how to proceed as CI seems to be broken in master as well...

@stalniy
Copy link
Owner

stalniy commented Feb 11, 2024

I’ll check. Thanks for the contribution!

@jarpoole jarpoole force-pushed the fix-rules-to-query-return-type-875 branch from c52583d to 48f968f Compare February 11, 2024 04:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e076b31) 94.93% compared to head (7b978ee) 94.98%.
Report is 61 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
+ Coverage   94.93%   94.98%   +0.04%     
==========================================
  Files          34       34              
  Lines         731      738       +7     
  Branches      175      177       +2     
==========================================
+ Hits          694      701       +7     
  Misses         20       20              
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stalniy stalniy merged commit 379e130 into stalniy:master Feb 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rulesToQuery should be generic over the return type of RuleToQueryConverter
3 participants