Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prisma): Add 'isSet' filter to prisma filters #967

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

p0thi
Copy link
Contributor

@p0thi p0thi commented Sep 8, 2024

As mentioned in #966 , using the isSet filter for optional field in prisma with mongodb is currently not possible.

This PR adds this functionality:

  • Add a new 'isSet' field instruction to PrismaQueryParser.
  • The 'isSet' instruction checks if an object value is defined when using the 'isSet' condition in a query.
  • Update the interpretPrismaQuery function to handle the new 'isSet' instruction.

@stalniy
Copy link
Owner

stalniy commented Sep 11, 2024

looks like there is some issue with env stuff, I will take a look but this will take some time. Thanks for contribution

@p0thi
Copy link
Contributor Author

p0thi commented Sep 11, 2024

looks like there is some issue with env stuff, I will take a look but this will take some time. Thanks for contribution

Thanks! Did I introduce this issues?

@stalniy stalniy force-pushed the master branch 3 times, most recently from 2085347 to 787bd00 Compare September 29, 2024 04:48
@stalniy
Copy link
Owner

stalniy commented Sep 29, 2024

THe issue relates to GHA, it doesn't share GH_TOKEN with non-collaborators, that's why GHA fails because it cannot run release action which should post a comment with explanation of what is changed and what is the next version.

I introduced this recently as part of automatic release management gha and tested it under my account, and obviously it worked because I'm the owner.

I'll try to find solution, if won't be able to do it, I will need to change release gha to be manual and then I'll trigger it via button

Add a new 'isSet' field instruction to PrismaQueryParser.
The 'isSet' instruction checks if an object value is defined when using the 'isSet' condition in a query.
Update the interpretPrismaQuery function to handle the new 'isSet' instruction.
@stalniy stalniy merged commit 256a2fe into stalniy:master Sep 29, 2024
5 of 6 checks passed
@stalniy
Copy link
Owner

stalniy commented Sep 29, 2024

Will release it during the next week. Cannot make it work for automated releases. Need more investigation

@stalniy
Copy link
Owner

stalniy commented Sep 29, 2024

released in @casl/[email protected]

Sorry for the long delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants