Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mcmc_pairs() return a ggplot object instead of a bayesplot_group object (Fix #268) #270

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

billdenney
Copy link
Contributor

This PR makes mcmc_pairs() return a ggplot object instead of a bayesplot_group object (Fix #268).

This is a DRAFT PR for review and comment!!! The reason that it is a draft is that it emits all sorts of warnings that would need to be fixed before merging, but I know that there are strong preferences about the graphical organization of the output of mcmc_pairs(), and I wanted to provide this draft to allow for testing and review. For a final PR, I would ensure that warnings were not present (or that they were minimized as much as possible).

I believe that I captured all the major functionality from the existing mcmc_pairs() output, but there were some interactions around how divergent transitions, max tree depth hits, and hex plots that may be off.

@billdenney
Copy link
Contributor Author

Some differences that I think are notable are:

  1. x-axes and y-axes are aligned now (because they are facets)
  2. row and column titles are now in strip labels instead of subtitles of the diagonal elements (again because they are facets)
  3. the vertical scale for the density or histogram plots along the diagonal are the full height of the facet rather than sharing the height with the subtitle

@jgabry
Copy link
Member

jgabry commented Jun 7, 2021

Hey @billdenney thank you for this and sorry for the slow reply! I'm caught up in a bunch of other stuff at the moment but hopefully I'll have time to give you some comments soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Make bayesplot_grid objects a ggplot object
2 participants