Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand checking workflows to more platforms #324

Merged
merged 6 commits into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,20 @@ jobs:
fail-fast: false
matrix:
config:
- {os: macos-latest, r: 'devel'}
- {os: macos-latest, r: 'release'}
- {os: macos-latest, r: 'oldrel'}
- {os: windows-latest, r: 'devel'}
- {os: windows-latest, r: 'release'}
- {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
- {os: windows-latest, r: 'oldrel'}
- {os: ubuntu-latest, r: 'devel'}
- {os: ubuntu-latest, r: 'release'}
- {os: ubuntu-latest, r: 'oldrel-1'}
- {os: ubuntu-latest, r: 'oldrel'}

env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
R_KEEP_PKG_SOURCE: yes
R_VERSION_TYPE: ${{ matrix.config.r }}

steps:
- uses: actions/checkout@v3
Expand All @@ -36,7 +41,6 @@ jobs:
- uses: r-lib/actions/setup-r@v2
with:
r-version: ${{ matrix.config.r }}
http-user-agent: ${{ matrix.config.http-user-agent }}
use-public-rspm: true

- uses: r-lib/actions/setup-r-dependencies@v2
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Suggests:
survival,
testthat (>= 2.0.0),
vdiffr (>= 1.0.2)
RoxygenNote: 7.3.0
RoxygenNote: 7.3.1
VignetteBuilder: knitr
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
4 changes: 1 addition & 3 deletions R/ppc-distributions.R
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,6 @@ ppc_violin_grouped <-
args_violin_y <- list(
data = function(x) dplyr::filter(x, .data$is_y),
aes(fill = "y", color = "y"),
show.legend = FALSE,
alpha = 0
)

Expand All @@ -561,8 +560,7 @@ ppc_violin_grouped <-
alpha = y_alpha,
size = y_size,
width = y_jitter,
height = 0,
show.legend = FALSE
height = 0
)

violin_y_func <- if (y_violin) geom_violin else geom_ignore
Expand Down
2 changes: 1 addition & 1 deletion R/ppc-test-statistics.R
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ ppc_stat_freqpoly <-
geom_vline(
data = dplyr::filter(data, .data$variable == "y"),
mapping = aes(xintercept = .data$value, color = "y"),
show.legend = FALSE,
show.legend = TRUE,
linewidth = 1
) +
scale_color_ppc(
Expand Down
60 changes: 30 additions & 30 deletions tests/testthat/_snaps/mcmc-diagnostics/mcmc-neff-default.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
54 changes: 27 additions & 27 deletions tests/testthat/_snaps/mcmc-diagnostics/mcmc-neff-hist-binwidth.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading