Move compilation code, deprecate constructing a model without ever compiling #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-2.0 part of #695
Submission Checklist
Summary
This moves the compilation code outside the model class and issues deprecation warnings for cases we'd like to disallow in 2.0, namely the use of a CmdStanModel without an executable at all.
I think if we get this in, I can update #691, and then we can release 1.2.0
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation.
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: