-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export helper functions #361
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9de9857 is merged into master:
|
Since these are being exported, would it be good to make the names of functions and arguments follow the same variable naming rules as other public functions? (eg |
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 609028d is merged into master:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 609028d is merged into master:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 419a1a3 is merged into master:
|
Looks good to me. Any changes you want to make before we merge? |
I think it should be good now |
great! merging now |
Summary
As discussed in #358, some internal functions could be useful for other packages (including
loo
andprojpred
).This PR adds documentation to, and exports, the following functions under a new family "helper-functions":
ps_khat_threshold
ps_min_ss
ps_tail_length
ps_convergence_rate
(not exported)gpdfit
It also updates the PSIS paper reference.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: