Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eight schools noncentered model in PyMC #264

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

fonnesbeck
Copy link

Updated eight schools noncentered model, using the current version of PyMC.

@MansMeg
Copy link
Collaborator

MansMeg commented Aug 12, 2024

Great!

Two things.

  1. You now committed the json data file. We keep the data as zip, so it must have been an accident?
  2. Also, there should not be any point of having an additional draws object from pyMC? It should be a true reference draw already.

So I suggest you remove these parts.

@fonnesbeck
Copy link
Author

Ah, forgot to zip them -- thanks!

@fonnesbeck
Copy link
Author

@MansMeg we are having a posteriordb hackathon today, so there should be a few PRs rolling in over the next few hours/days. Happy to lend a hand if you need.

Let me know if anything else needs changing for this example.

@fonnesbeck
Copy link
Author

Is there anything else required here?

@MansMeg
Copy link
Collaborator

MansMeg commented Aug 23, 2024

Sorry. Courses are starting so its currently a lot pn my table.

@fonnesbeck
Copy link
Author

Understood, no problem! We (the PyMC team) are hoping to implement a bunch of these models in the current version of PyMC over the next few weeks or so. Given your constraints, would you recommend having us fork the project and then you can move them over when you have time?

@MansMeg
Copy link
Collaborator

MansMeg commented Aug 23, 2024

Hi! Yes. That is probably the best if you want to use the models asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants