-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 587 expose hessians #590
Open
rgiordan
wants to merge
12
commits into
stan-dev:develop
Choose a base branch
from
rgiordan:feature/issue-587-expose-hessians
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/issue 587 expose hessians #590
rgiordan
wants to merge
12
commits into
stan-dev:develop
from
rgiordan:feature/issue-587-expose-hessians
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This depends on stan-dev/stan#2701. |
Can one of the admins verify this patch? |
This particular PR is surely out of date. I do think it would be great to have some clarity over whether Stan might support exposing these methods even if in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to clarify and focus conversation on #587.
Summary:
Expose Hessian methods of the stan model in the
stanfit
object.Intended Effect:
Provide the functions
rstan::hessian_log_prob
andrstan::hessian_times_vector_log_prob
that work analogously torstan::grad_log_prob
.How to Verify:
TBD with the help of the Stan team.
Side Effects:
None.
Documentation:
TBD with the help of the Stan team.
Reviewer Suggestions:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Ryan Giordano
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: