Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in quality gate filter #3216

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

serban-nicusor-toptal
Copy link
Contributor

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Fix a typo in the quality gate filter, this fails downstream tests in Math by being unstable, see pipeline.

Intended Effect

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Toptal

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does CmdStan need the same change?

@serban-nicusor-toptal
Copy link
Contributor Author

In cmdstan we only have warnings from

clang: warning: -Wl,-L,/Users/jenkins/workspace/Stan_CmdStan_develop/stan/lib/stan_math/lib/tbb: 'linker' input unused [-Wunused-command-line-argument]

So the following filter does the trick:

excludeFile('stan/lib/stan_math/lib/*')

@WardBrian
Copy link
Member

stan-dev/cmdstan#1143 has the quality gate complaining

@serban-nicusor-toptal
Copy link
Contributor Author

Oh, that's weird, it comes from the MacOS SDK

stan/lib/stan_math/lib/boost_1.78.0/boost/assert/source_location.hpp:80:18: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
            std::sprintf( buffer, ":%ld", static_cast<long>( column() ) );
                 ^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
__deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
        #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                      ^

And the Jenkins plugin sees it as a different warning/path. I'll run a new build on your PR to try and filter it.

@serban-nicusor-toptal serban-nicusor-toptal changed the title Fixed typo in quality gate filter Fix typo in quality gate filter Aug 8, 2023
@serban-nicusor-toptal serban-nicusor-toptal merged commit 643eee4 into develop Aug 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants