Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the shell extension #30

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Improve the shell extension #30

merged 3 commits into from
Apr 24, 2019

Conversation

gcampax
Copy link
Contributor

@gcampax gcampax commented Apr 24, 2019

A partial fix to #24 . Not quite as polished as I hoped but still better.

gcampax added 3 commits April 24, 2019 10:05
Make it cooperate better with the app
So we can configure devices from the extension, if needed
@gcampax
Copy link
Contributor Author

gcampax commented Apr 24, 2019

This pull request introduces 3 alerts when merging e7fc9ff into 2007aba - view on LGTM.com

new alerts:

  • 1 for Variable not declared before use
  • 1 for Property access on null or undefined
  • 1 for Access to let-bound variable in temporal dead zone

Comment posted by LGTM.com

@gcampax gcampax merged commit 5b12fda into master Apr 24, 2019
@gcampax gcampax deleted the wip/improve-shell-extension branch November 8, 2019 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant