Major Cleanup #1 #252
Merged
Major Cleanup #1 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these were inherited from decaNLP but the implementations are old and no longer used. We can import similar metrics from HF/datasets library.
Mehrad0711
force-pushed
the
wip/mehrad/cleanups
branch
from
ff40c58 to
83cbff2
Compare
Mehrad0711
force-pushed
the
wip/mehrad/cleanups
branch
from
83cbff2 to
5ccaa1a
Compare
s-jse
requested changes
Mar 1, 2022
There was a problem hiding this comment.
Thanks, overall is a good cleanup, but you should make a few changes before merging it. Please see the individual comments.
Also, have you tested this code with old non-multilingual models? What about the genie-k8s scripts? Especially since you have removed training/prediction arguments.
Mehrad0711
force-pushed
the
wip/mehrad/cleanups
branch
from
3df2253 to
8833a1b
Compare
s-jse
reviewed
Mar 2, 2022
Mehrad0711
force-pushed
the
wip/mehrad/cleanups
branch
from
aa3210a to
91c3031
Compare
|
This pull request fixes 3 alerts when merging 91c3031 into a5089ae - view on LGTM.com fixed alerts:
|
s-jse
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cleanup for genienlp has been long overdue!
We've collected quite some technical debt which we need to address. We have created a project dashboard to keep track of issues we want to address. I've moved the cards this PR addresses to "In progress".
The goal of this series of cleanups is to simplify the code, make it more readable, easier to modify, and more inviting for outside collaborators.
There are no functional changes (besides dropping almond_multilingual tasks and associated code) - tests are still passing.
We're dropping support for old generic datasets and associated metrics which were inherited from decaNLP code.
Those implementations are obsolete and should be replaced with what is now accessible through datasets library. Please see issue. If you want support for a new dataset, feel free to submit a PR for it.