Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove STORM paper specific experiment dir and readme from main branch #184

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Yucheng-Jiang
Copy link
Collaborator

@Yucheng-Jiang Yucheng-Jiang commented Sep 25, 2024

As title, remove ./FreshWiki, ./eval and NAACL replicate experiments instructions in README from main branch as they are duplicates in NAACL-BACKUP branch.

Action item: I will copy FreshWiki license to NAACL backup branch in a separate commit.

@shaoyijia
Copy link
Collaborator

Could you add a Dataset section in README.md so people can know our project also contributes datasets?

@Yucheng-Jiang
Copy link
Collaborator Author

Yucheng-Jiang commented Sep 25, 2024

Could you add a Dataset section in README.md so people can know our project also contributes datasets?

Sure! Will resolve it in in PR #185. Or would you prefer to add a dataset directory in main root?

@shaoyijia
Copy link
Collaborator

We could maintain them in branches. Could we also make a zip file and upload to our project google drive and share the link? In this way,
people can directly download the zip file if they don't want to checkout the branches.

@Yucheng-Jiang
Copy link
Collaborator Author

Sounds good!

@Yucheng-Jiang Yucheng-Jiang merged commit 33a03a3 into main Sep 25, 2024
1 check passed
@Yucheng-Jiang Yucheng-Jiang deleted the main-branch-cleanup branch September 25, 2024 04:59
feldges pushed a commit to feldges/storm that referenced this pull request Dec 4, 2024
…leanup

remove STORM paper specific experiment dir and readme from main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants