Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New RM] Add AzureAISearch #198

Merged
merged 5 commits into from
Oct 19, 2024
Merged

[New RM] Add AzureAISearch #198

merged 5 commits into from
Oct 19, 2024

Conversation

dfusion-dev
Copy link

@dfusion-dev dfusion-dev commented Oct 7, 2024

Goal

Add RM support for Azure AI Search. Allows the use of custom datasets made available through Azure AI Search.

Changes

  • Updated requirements.txt to include azure-search-documents. This SDK wraps Azure's AI Search functionality.
  • Updated rm.py to include AzureAISearch implementation.
  • Updated the example script, run_storm_wiki_gpt.py, to include AzureAISearch support.
  • Updated README.md to include the new retrieval module component

Change Questions / Comments

We could do something akin to what was done for Google Search support: rather than install as part of requirements.txt, have the RM fail unless the user installs the proper pypi library.

Generated Files

I've attached a zip of the artifacts generated running the run_storm_wiki_gpt.py using the new rm. Data for the article sourced from part of dFusion's Genesis Knowledge Pool made available through Azure AI Search. Files in the zip include:

  • conversation_log.json
  • raw_search_results.json
  • storm_gen_article.txt
  • direct_gen_outline.txt
  • run_config.json
  • storm_gen_outline.txt
  • llm_call_history.jsonl
  • storm_gen_article_polished.txt
  • url_to_info.json

Formal_Verification_In_Smart_Contract_Development.tar.gz

@shaoyijia shaoyijia self-assigned this Oct 8, 2024
Copy link
Collaborator

@shaoyijia shaoyijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution! We are happy to integrate this once you fix the nits.

knowledge_storm/rm.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
knowledge_storm/rm.py Outdated Show resolved Hide resolved
@dfusion-dev
Copy link
Author

@shaoyijia requested changes have been applied

@dfusion-dev dfusion-dev requested a review from shaoyijia October 16, 2024 21:33
Copy link
Collaborator

@shaoyijia shaoyijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this!

@shaoyijia shaoyijia merged commit 18d0258 into stanford-oval:main Oct 19, 2024
1 check passed
feldges pushed a commit to feldges/storm that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants