Genres #399
Open
Genres #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 5 alerts when merging 74cae92 into 7c00e04 - view on LGTM.com new alerts:
|
|
Ok, unrelated Travis errors are solved now, but there are other errors specific to the movie skill that needs to be fixed before this can be merged. |
|
This pull request introduces 5 alerts when merging c285a7a into eed526e - view on LGTM.com new alerts:
|
|
This pull request introduces 5 alerts when merging 61e0053 into 67f5901 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging b20732b into e98aaae - view on LGTM.com new alerts:
|
gcampax
reviewed
Aug 20, 2021
universe/org.themoviedb/index.js
Outdated
| const movieObj = { | ||
| id, | ||
| description: result.overview, | ||
| release_date: oneDate, | ||
| rating_score: Number(result.vote_average), | ||
| genres: result.genre_ids, |
There was a problem hiding this comment.
You should map the genre IDs to an array of Entity objects containing the genre names as well, otherwise the agent won't be able to speak out the genre name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.