Parallel BootstrapFewShot, BootstrapKNN (and +WithRandomSearch) #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2024 15:26
CyrusNuevoDia
force-pushed
the
parallel-bootstrap
branch
from
f3f1ed8
to
254c8e5
Compare
|
Not sure why there's an error in the test, I didn't modify anything there |
CyrusNuevoDia
changed the title
|
That's just a race condition |
|
@krypticmouse ah, just a flaky test then? |
|
@CyrusOfEden yea I'll work on making this a bit more deterministic, quite random rn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BootstrapFewShot and BootstrapKNN have been parallelized :)
The diff is kinda messy since lines were moved around, would recommend just looking at the new file.