Elastic Search retriever module integration #534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great.
|
|
Modification done |
Thank you! One more, it would be great if you could add the note for the new client in this folder.
|
|
Done! |
|
Great, thank you. |
|
tagging @isaacbmiller on failed tests. similar issues to previous PRs - could be related to #569 ? |
|
@pmenkidoo @arnavsinghvi11 Try merging main and pushing again |
|
@pmenkidoo just following up on this. can you rebase+merge with main and push again? the PR should be good to merge after that! |
|
Will do.
…On Sun, Mar 24, 2024, 4:10 PM arnavsinghvi11 ***@***.***> wrote:
@pmenkidoo <https://github.com/pmenkidoo> just following up on this. can
you rebase+merge with main and push again? the PR should be good to merge
after that!
—
Reply to this email directly, view it on GitHub
<#534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALKD26MNU73TZFNRAUNBGW3YZ4XLLAVCNFSM6AAAAABEDS2TLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHEZDSNBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hello,
I am not sure what does it mean to Rebase.
…On Thu, Mar 28, 2024 at 4:56 PM Pholysa Mantryvong ***@***.***> wrote:
Will do.
On Sun, Mar 24, 2024, 4:10 PM arnavsinghvi11 ***@***.***>
wrote:
> @pmenkidoo <https://github.com/pmenkidoo> just following up on this. can
> you rebase+merge with main and push again? the PR should be good to merge
> after that!
>
> —
> Reply to this email directly, view it on GitHub
> <#534 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALKD26MNU73TZFNRAUNBGW3YZ4XLLAVCNFSM6AAAAABEDS2TLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHEZDSNBVHA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
Pholysa Mantryvong
ENKIDOO.ai
W: enkidoo.ai
E: ***@***.***
[image: facebook][image: linkedIn]
<https://www.linkedin.com/company/enkidoo-technologies-inc-/>
DISCLAIMER: This email and any files transmitted with it are confidential
and intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify the
system manager. This message contains confidential information and is
intended only for the individual named. If you are not the named addressee
you should not disseminate, distribute or copy this e-mail. Please notify
the sender immediately by e-mail if you have received this e-mail by
mistake and delete this e-mail from your system. If you are not the
intended recipient you are notified that disclosing, copying, distributing
or taking any action in reliance on the contents of this information is
strictly prohibited.
|
|
Hi @pmenkidoo , You have to fetch and rebase the latest changes from the Feel free to follow these steps |
|
Hi, is there any plans to merge this into main? |
|
Hello,
My apologies.
Forgot about this. If the code baae has changed a lot, will need to test it
again.
Should expect a merge this week/weekend.
…On Thu, Nov 7, 2024, 12:56 AM Alvin Ng ***@***.***> wrote:
Hi, is there any plans to merge this into main?
—
Reply to this email directly, view it on GitHub
<#534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALKD26JWVTM3NQMDB7OOYB3Z7L6IZAVCNFSM6AAAAABRKNBBJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRRGM4DSNJYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A retriever module for Elastic Search build during the course of NLU - xCSS224U - Spring 2024.
It returns top k document passage sorted based on standard elastic search - query and algorithm.