-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dspy): together client response parsing bug + endpoint #627
Conversation
Thanks @adam-simple ! LGTM, but @insop do you want to run some checks on this? (since you added the Together client :). |
Thank you @arnavsinghvi11 for looping me. @adam-simple I was using this API base as follows, and when you use this API_BASE, it was correct in both API URL and the
But, when I check the API doc, So your change is great to remove the deprecated url. If you could consider the follow two, it will be great.
|
@adam-simple it's not working I've tried the fix you mentioned can you please inform what did you set for TOGETHER_API_BASE |
Please seem y post above and that's what I was suggesting. |
I resolved this issue by using the OpenAI compatability together has. I created another handler for together. using existing one was too much hassle for me. If anyone needed here is the branch for fix: |
Oops I spoke too fast. OK it seems that this is good to go once the issue faced by @someshfengde is fixed |
Hi @someshfengde , did you want to add your changes for Together to this PR? maybe the ones that were removed from the other PR? |
I'd have to open a different PR ig? right? |
@adam-simple @someshfengde should this PR be closed? |
I opened up a related issue just now #626
Basically I was getting errors when using the Together client. If I set use_chat_api to true, the response did not have an "output" field. Also, if I set use_chat_api to false, I get a 404. These changes fix these issues.
I've only done a smoke test. probably worth at least a smoke test by whoever is reviewing this as well.