Add oauth_console authentication type #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
hovaesco
force-pushed
the
hovaesco/oauth-console
branch
from
bdac979
to
b0beb8e
Compare
damian3031
reviewed
Dec 1, 2023
There was a problem hiding this comment.
Please add test_oauth_console_authentication test to https://github.com/starburstdata/dbt-trino/blob/v1.7.0/tests/unit/test_adapter.py
hovaesco
force-pushed
the
hovaesco/oauth-console
branch
from
b0beb8e
to
745fbfe
Compare
Done |
damian3031
approved these changes
Dec 1, 2023
damian3031
reviewed
Dec 1, 2023
mdesmet
approved these changes
Dec 1, 2023
hovaesco
force-pushed
the
hovaesco/oauth-console
branch
from
745fbfe
to
4130306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checklist
README.mdupdated and added information about my changechangie newto create a changelog entry