Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add block_connector_service to miner #4141

Merged
merged 5 commits into from
Jun 20, 2024
Merged

add block_connector_service to miner #4141

merged 5 commits into from
Jun 20, 2024

Conversation

simonjiao
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@simonjiao simonjiao marked this pull request as draft June 19, 2024 04:22
@simonjiao simonjiao force-pushed the replace-chain-with-connector-service branch from 82cd579 to 99130f9 Compare June 19, 2024 05:26
@github-actions GitHub Actions
Copy link

Benchmark for 543b10f

Click to view benchmark
Test Base PR %
accumulator_append 920.2±202.89µs 789.0±105.13µs -14.26%
block_apply/block_apply_10 368.9±7.81ms 374.1±11.80ms +1.41%
block_apply/block_apply_1000 42.1±1.43s 41.8±2.96s -0.71%
get_with_proof/db_store 49.3±6.98µs 49.7±2.87µs +0.81%
get_with_proof/mem_store 40.6±4.45µs 39.1±2.91µs -3.69%
put_and_commit/db_store/1 122.9±9.62µs 179.7±41.79µs +46.22%
put_and_commit/db_store/10 1149.1±227.33µs 1180.3±167.47µs +2.72%
put_and_commit/db_store/100 13.1±3.69ms 9.9±1.07ms -24.43%
put_and_commit/db_store/5 537.4±36.75µs 620.8±131.38µs +15.52%
put_and_commit/db_store/50 5.4±0.60ms 5.6±0.84ms +3.70%
put_and_commit/mem_store/1 84.7±17.14µs 86.2±23.65µs +1.77%
put_and_commit/mem_store/10 690.4±56.82µs 750.2±108.15µs +8.66%
put_and_commit/mem_store/100 7.0±1.15ms 6.8±0.46ms -2.86%
put_and_commit/mem_store/5 365.7±61.35µs 343.9±32.14µs -5.96%
put_and_commit/mem_store/50 3.4±0.27ms 3.4±0.28ms 0.00%
query_block/query_block_in(10)_times(100) 5.5±1.14ms 4.6±0.19ms -16.36%
query_block/query_block_in(10)_times(1000) 45.4±2.83ms 50.9±9.51ms +12.11%
query_block/query_block_in(10)_times(10000) 530.5±85.68ms 463.8±20.28ms -12.57%
query_block/query_block_in(1000)_times(100) 1196.3±49.72µs 1492.8±320.06µs +24.78%
query_block/query_block_in(1000)_times(1000) 12.1±0.55ms 12.6±1.60ms +4.13%
query_block/query_block_in(1000)_times(10000) 124.7±4.11ms 131.7±17.49ms +5.61%
storage_transaction 1252.4±524.40µs 1076.1±411.49µs -14.08%
vm/transaction_execution/1 496.5±77.31ms 455.0±31.76ms -8.36%
vm/transaction_execution/10 151.9±8.47ms 138.0±12.94ms -9.15%
vm/transaction_execution/20 137.7±13.54ms 127.5±5.90ms -7.41%
vm/transaction_execution/5 178.3±15.04ms 191.0±18.94ms +7.12%
vm/transaction_execution/50 156.1±16.34ms 146.0±8.98ms -6.47%

@simonjiao
fix tests
f22d8d7
@simonjiao
remove unused codes
58a7046 
* remove BlockChain/BlockDag
* remove uncles updating logic for single chain
@simonjiao
use dagtest network for miner_service test
e4ec216
@github-actions GitHub Actions
Copy link

Benchmark for e67a542

Click to view benchmark
Test Base PR %
accumulator_append 1022.0±276.97µs 809.5±148.55µs -20.79%
block_apply/block_apply_10 368.8±14.64ms 398.3±26.79ms +8.00%
block_apply/block_apply_1000 41.3±1.26s 42.1±0.90s +1.94%
get_with_proof/db_store 46.8±1.98µs 48.0±3.66µs +2.56%
get_with_proof/mem_store 38.4±3.34µs 45.1±8.86µs +17.45%
put_and_commit/db_store/1 119.1±7.05µs 119.2±7.83µs +0.08%
put_and_commit/db_store/10 1133.0±81.74µs 1030.9±48.12µs -9.01%
put_and_commit/db_store/100 11.4±2.14ms 10.0±0.99ms -12.28%
put_and_commit/db_store/5 601.3±146.23µs 664.2±139.06µs +10.46%
put_and_commit/db_store/50 5.2±0.42ms 5.1±0.36ms -1.92%
put_and_commit/mem_store/1 84.9±19.65µs 80.2±18.32µs -5.54%
put_and_commit/mem_store/10 694.0±67.06µs 691.4±80.54µs -0.37%
put_and_commit/mem_store/100 7.0±1.00ms 6.5±0.34ms -7.14%
put_and_commit/mem_store/5 357.9±38.14µs 350.0±35.38µs -2.21%
put_and_commit/mem_store/50 3.7±0.88ms 3.6±0.55ms -2.70%
query_block/query_block_in(10)_times(100) 4.7±0.25ms 4.7±0.20ms 0.00%
query_block/query_block_in(10)_times(1000) 48.4±3.20ms 58.8±17.84ms +21.49%
query_block/query_block_in(10)_times(10000) 570.4±125.98ms 479.0±24.20ms -16.02%
query_block/query_block_in(1000)_times(100) 1465.5±266.58µs 1230.2±86.96µs -16.06%
query_block/query_block_in(1000)_times(1000) 12.2±0.43ms 13.1±1.88ms +7.38%
query_block/query_block_in(1000)_times(10000) 134.3±24.92ms 138.1±27.24ms +2.83%
storage_transaction 1206.3±527.57µs 1144.2±457.71µs -5.15%
vm/transaction_execution/1 446.1±24.85ms 429.5±21.89ms -3.72%
vm/transaction_execution/10 133.7±5.46ms 167.1±42.95ms +24.98%
vm/transaction_execution/20 134.7±7.75ms 138.8±9.07ms +3.04%
vm/transaction_execution/5 170.2±10.66ms 165.7±5.27ms -2.64%
vm/transaction_execution/50 153.6±10.38ms 150.2±10.14ms -2.21%

@simonjiao simonjiao marked this pull request as ready for review June 19, 2024 22:45
sanlee42
sanlee42 approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@sanlee42 sanlee42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It means the minted block, relayed block and sync block all processed by BlockConnectorService. Great.

@simonjiao simonjiao merged commit 8e91a0b into dag-master Jun 20, 2024
5 checks passed
@simonjiao simonjiao deleted the replace-chain-with-connector-service branch June 20, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanlee42 sanlee42 sanlee42 approved these changes

@nkysg nkysg Awaiting requested review from nkysg nkysg is a code owner

@jackzhhuang jackzhhuang Awaiting requested review from jackzhhuang

@welbon welbon Awaiting requested review from welbon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjiao @sanlee42