Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cmake_utils/gen_venv.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

def filter_interpreter(python: str, entries: List[str]):
"""
Filters given list of entries by interpreter prefix.
Filters are given a list of entries by interpreter prefix.
Example:
filter_interpreter('prefix0', ['a', 'b', 'prefix0:c' ,'prefix1:d']) == \
['a', 'b', 'c']
Expand Down
2 changes: 1 addition & 1 deletion src/cmake_utils/pip_rules.cmake
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Note: STAMP_FILE is a dummy output file for a target that holds all of the reqeuired file level
# Note: STAMP_FILE is a dummy output file for a target that holds all of the required file level
# dependencies of the target. If you have a custom command that needs a dependency target to run
# before, it should depend on the target and the stamp file.

Expand Down
4 changes: 2 additions & 2 deletions src/cmake_utils/python_rules.cmake
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# CACHE INTERNAL makes the variables definitions available in every scope.
# CACHE INTERNAL makes the definitions of the variables available in every scope.
set(GEN_PY_LIB_EXECUTABLE ${CMAKE_CURRENT_LIST_DIR}/gen_py_lib.py CACHE INTERNAL "")
set(GEN_VENV_EXECUTABLE ${CMAKE_CURRENT_LIST_DIR}/gen_venv.py CACHE INTERNAL "")
set(GEN_PYTHON_EXE_EXECUTABLE ${CMAKE_CURRENT_LIST_DIR}/gen_python_exe.py CACHE INTERNAL "")
Expand Down Expand Up @@ -125,7 +125,7 @@ endfunction()
# Creates a virtual environment target.
# Usage: python_venv(venv_name PYTHON ${PYTHON_COMMAND} LIBS lib0 lib1 ...)
# Target properties:
# VENV_PYTHON: Full path to the vritual environment python executable.
# VENV_PYTHON: Full path to the virtual environment python executable.
# STAMP_FILE: when this file is generated, the virtual environment is ready to use.
function(python_venv VENV_NAME)
# Parse arguments.
Expand Down
4 changes: 2 additions & 2 deletions src/starkware/cairo/lang/cairo_cmake_rules.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ function(cairo_compile_base TARGET_NAME COMPILER_EXE COMPILED_PROGRAM_NAME SOURC
# Choose a file name for the Cairo dependencies of the compiled file.
set(COMPILE_DEPENDENCY_FILE
"${CMAKE_CURRENT_BINARY_DIR}/${TARGET_NAME}_compile_dependencies.cmake")
# If this is the first build, create an empty dependency file (this file will be overriden when
# If this is the first build, create an empty dependency file (this file will be overridden when
# cairo-compile is executed with the actual dependencies, using the --cairo_dependencies flag).
if(NOT EXISTS ${COMPILE_DEPENDENCY_FILE})
file(WRITE ${COMPILE_DEPENDENCY_FILE} "")
Expand Down Expand Up @@ -60,7 +60,7 @@ function(cairo_compile_run TARGET_NAME FILENAME STEPS ARTIFACTS COMPILE_FLAGS RU

# Choose a file name for the python dependencies of cairo-run.
set(RUN_DEPENDENCY_FILE "${CMAKE_CURRENT_BINARY_DIR}/${FILENAME}_run_dependencies.cmake")
# If this is the first build, create an empty dependency file (this file will be overriden when
# If this is the first build, create an empty dependency file (this file will be overridden when
# cairo-run is executed with the actual dependencies, using the --python_dependencies flag).
if(NOT EXISTS ${RUN_DEPENDENCY_FILE})
file(WRITE ${RUN_DEPENDENCY_FILE} "")
Expand Down
4 changes: 2 additions & 2 deletions src/starkware/solidity/interfaces/ProxySupport.sol
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import "./ContractInitializer.sol";
abstract contract ProxySupport is Governance, BlockDirectCall, ContractInitializer {
using Addresses for address;

// The two function below (isFrozen & initialize) needed to bind to the Proxy.
// The two function below (isFrozen & initialize) are needed to bind to the Proxy.
function isFrozen() external view virtual returns (bool) {
return false;
}
Expand All @@ -29,7 +29,7 @@ abstract contract ProxySupport is Governance, BlockDirectCall, ContractInitializ
1. This function cannot be called directly on the deployed contract, but only via
delegate call.
2. If an EIC is provided - init is passed onto EIC and the standard init flow is skipped.
This true for both first intialization or a later one.
This is true for both first initialization or a later one.
3. The data passed to this function is as follows:
[sub_contracts addresses, eic address, initData].

Expand Down