Skip to content

Commit

Permalink
Merge pull request #2420 from starknet-io/dev
Browse files Browse the repository at this point in the history
Merge dev into production
  • Loading branch information
igalst authored Feb 11, 2024
2 parents 8f873e1 + 117ae18 commit c456d29
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 10 deletions.
4 changes: 2 additions & 2 deletions _data/settings/main-menu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ items:
custom_external_link: https://starknet.io/discord
- custom_title: GitHub
custom_icon: SiGithub
custom_external_link: https://github.com/starknet-io/starknet-website
custom_external_link: https://github.com/keep-starknet-strange/awesome-starknet
- custom_title: Twitter
custom_icon: SiTwitter
custom_internal_link: ""
Expand All @@ -103,4 +103,4 @@ items:
- custom_title: Starknet Edu Blog
custom_external_link: https://medium.com/starknet-edu
hide_from_footer: true

4 changes: 4 additions & 0 deletions _data/settings/permissions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,7 @@ items:
name: Tal Levin
access:
- all
- username: igalst
name: Igal Steklov
access:
- all
4 changes: 2 additions & 2 deletions workspaces/netlify-cms-backend-github/src/API.ts
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ export default class API {
environment: `Starknet Website ${branch}`,
}
});

if (!(shaPreviewDeployments?.length > 0)) {
throw new EditorialWorkflowError(
"No preview deployment found for this commit",
Expand Down Expand Up @@ -1183,7 +1183,7 @@ export default class API {

const user = await this.user()
const permissions = await res.json();
const userPermissions: {username: string, access: Array<string>} = permissions.find(p => p.username = user.login)
const userPermissions: {username: string, access: Array<string>} = permissions.find(p => p.username === user.login)
if(!userPermissions){
throw new Error(`No permissions found in CMS for user "${user.login}"`)
}
Expand Down
12 changes: 6 additions & 6 deletions workspaces/website/src/components/Footer/Footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const Root = ({ children, seo, ...rest }: RootProps) => {
opacity="1"
display={{ base: "flex", md: "none" }}
/>
<Stack
<Stack
pt="40px"
pb={{ base: "40px", md: "0px" }}
px="30px"
Expand Down Expand Up @@ -111,9 +111,9 @@ const Root = ({ children, seo, ...rest }: RootProps) => {
px="30px"
justifyContent={{ md: "space-between"}}
>
<Stack
gap={{ base: "24px", md: "0px" }}
direction={{ base: "column", md: "row" }}
<Stack
gap={{ base: "24px", md: "0px" }}
direction={{ base: "column", md: "row" }}
align={{ base: "start", md: "center" }}
height={{ base: "auto", md: "32px" }}
spacing="16px"
Expand All @@ -132,7 +132,7 @@ const Root = ({ children, seo, ...rest }: RootProps) => {
{seo?.footerText}
</Text>
</Stack>
<Stack
<Stack
display={{ base: "none", xl: "flex" }}
direction="row"
gap="30px"
Expand Down Expand Up @@ -166,7 +166,7 @@ const Root = ({ children, seo, ...rest }: RootProps) => {
/>
<IconButton
as="a"
href="https://github.com/starknet-io/starknet-website"
href="https://github.com/keep-starknet-strange/awesome-starknet"
aria-label="GitHub"
icon={<SiGithub fontSize="1.25rem" />}
size="small"
Expand Down

0 comments on commit c456d29

Please sign in to comment.