Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing button to change the text and url depend on the size of the screen #2836

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Editing button to change the text and url depend on the size of the screen #2836

wants to merge 3 commits into from

Conversation

TalBenAvi
Copy link
Collaborator

@TalBenAvi TalBenAvi commented May 7, 2024 •
edited
Loading

deleted

@TalBenAvi TalBenAvi temporarily deployed to Netlify CMS changing-bridge-button-on-mobile May 8, 2024 12:17 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Storybook changing-bridge-button-on-mobile May 8, 2024 12:17 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi temporarily deployed to Starknet Website changing-bridge-button-on-mobile May 8, 2024 12:17 — with GitHub Actions Inactive
@TalBenAvi TalBenAvi requested a review from igalst May 8, 2024 12:17
@igalst igalst changed the title editing button to change the text and url depend on the size of the screen Editing button to change the text and url depend on the size of the screen May 8, 2024
igalst
igalst requested changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@igalst igalst left a comment •
edited by TalBenAvi
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Render 2 buttons, and with CSS (not JS) show/hide the one that we want
  • Since Google indexes Mobile-first, we need to understand which button the the indexed and how it affects SEO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalst igalst igalst requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TalBenAvi @igalst