Skip to content

Commit

Permalink
chore: remove url-join, fix JSDocs & typo
Browse files Browse the repository at this point in the history
  • Loading branch information
lukasaric committed Sep 5, 2024
1 parent 025eb93 commit b0a7c68
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 22 deletions.
17 changes: 1 addition & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@
"@types/jest": "^29.5.0",
"@types/jest-json-schema": "^6.1.1",
"@types/pako": "^2.0.0",
"@types/url-join": "^4.0.1",
"@typescript-eslint/eslint-plugin": "^7.4.0",
"@typescript-eslint/parser": "^7.4.0",
"ajv": "^8.12.0",
Expand Down Expand Up @@ -105,8 +104,7 @@
"lossless-json": "^4.0.1",
"pako": "^2.0.4",
"starknet-types-07": "npm:@starknet-io/types-js@^0.7.7",
"ts-mixer": "^6.0.3",
"url-join": "^4.0.1"
"ts-mixer": "^6.0.3"
},
"lint-staged": {
"*.ts": "eslint --cache --fix",
Expand Down
1 change: 1 addition & 0 deletions src/types/lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { weierstrass } from '../../utils/ec';
import { EDataAvailabilityMode, ResourceBounds } from '../api';
import { CairoEnum } from '../cairoEnum';
import { CompiledContract, CompiledSierraCasm, ContractClass } from './contract';
import { ValuesType } from '../helpers/valuesType';

export type WeierstrassSignatureType = weierstrass.SignatureType;
export type ArraySignatureType = string[];
Expand Down
4 changes: 2 additions & 2 deletions src/utils/encode.ts
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,8 @@ export function sanitizeBytes(
* ```
*/
export function sanitizeHex(hex: string): string {
const hexWihtoutPrefix = removeHexPrefix(hex);
const sanitizedHex = sanitizeBytes(hexWihtoutPrefix, 2);
const hexWithoutPrefix = removeHexPrefix(hex);
const sanitizedHex = sanitizeBytes(hexWithoutPrefix, 2);
return sanitizedHex ? addHexPrefix(sanitizedHex) : sanitizedHex;
}

Expand Down
2 changes: 1 addition & 1 deletion src/utils/stark.ts
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ export function toTransactionVersion(
/**
* Convert Transaction version to Fee version or throw an error
* @param {BigNumberish} [providedVersion] 0..3 number representing the transaction version
* @returns {TransactionVersion} the fee estimation version corresponding to the transaction version provided
* @returns {ETransactionVersion | undefined} the fee estimation version corresponding to the transaction version provided
* @throws {Error} if the transaction version is unknown
* @example
* ```typescript
Expand Down

0 comments on commit b0a7c68

Please sign in to comment.