Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert companion pattern except constants #1193

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

lukasaric
Copy link
Contributor

@lukasaric lukasaric commented Aug 2, 2024

Motivation and Resolution

Use companion pattern instead because of the type safety except constants to avoid build issues.
Tested by linking the newly built version within Starknet Wallet Account (linked it locally, also tested packed variant of project).

Next steps for new PR’s:

RPC version (if applicable)

Usage related changes

n.a

Development related changes

n.a

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@lukasaric lukasaric marked this pull request as draft August 2, 2024 18:28
@lukasaric lukasaric changed the title chore: use unbuild & revert enums replacement chore: revert companion pattern except constants Aug 21, 2024
@lukasaric lukasaric marked this pull request as ready for review August 21, 2024 10:04
@ivpavici ivpavici requested a review from PhilippeR26 August 21, 2024 14:24
@ivpavici
Copy link
Collaborator

@PhilippeR26 when you catch some time, could you test this solution please 🙏

Copy link
Collaborator

@PhilippeR26 PhilippeR26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the cases of #1137 .
Still the same problem.
I see zero improvement.

@lukasaric
Copy link
Contributor Author

I tested the cases of #1137 . Still the same problem. I see zero improvement.

As I said in the description, this issue is not covered via this PR (that’s a next step for a new follow up PR). I’ll update description to be more clear

@PhilippeR26
Copy link
Collaborator

I tested the cases of #1137 . Still the same problem. I see zero improvement.

As I said in the description, this issue is not covered via this PR (that’s a next step for a new follow up PR). I’ll update description to be more clear
🤔
So, what can be tested to verify this PR?

@lukasaric
Copy link
Contributor Author

lukasaric commented Aug 22, 2024

I tested the cases of #1137 . Still the same problem. I see zero improvement.

As I said in the description, this issue is not covered via this PR (that’s a next step for a new follow up PR). I’ll update description to be more clear
🤔
So, what can be tested to verify this PR?

Build needs to be tested in projects that are using starknet. I tested with your starknet wallet account repo and it’s working fine, but I wanted to double check with the author :)

@PhilippeR26
Copy link
Collaborator

PhilippeR26 commented Aug 23, 2024

Understood.
I have tested with :

Copy link
Collaborator

@penovicp penovicp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned a possible documentation issue. In general, double-checking how the documentation is affected might be worthwhile.

Aside from that lgtm

src/types/api/rpcspec_0_6/contract.ts Show resolved Hide resolved
Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@tabaktoni tabaktoni merged commit ebf9f35 into starknet-io:develop Sep 3, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 3, 2024
## [6.13.1](v6.13.0...v6.13.1) (2024-09-03)

### Bug Fixes

* revert companion pattern except constants ([#1193](#1193)) ([ebf9f35](ebf9f35))
Copy link

github-actions bot commented Sep 3, 2024

🎉 This issue has been resolved in version 6.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems to use RPCSPEC06 and RPCSPEC07 namespaces
5 participants