-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: revert companion pattern except constants #1193
chore: revert companion pattern except constants #1193
Conversation
@PhilippeR26 when you catch some time, could you test this solution please 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the cases of #1137 .
Still the same problem.
I see zero improvement.
As I said in the description, this issue is not covered via this PR (that’s a next step for a new follow up PR). I’ll update description to be more clear |
|
Build needs to be tested in projects that are using starknet. I tested with your starknet wallet account repo and it’s working fine, but I wanted to double check with the author :) |
Understood.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned a possible documentation issue. In general, double-checking how the documentation is affected might be worthwhile.
Aside from that lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit
## [6.13.1](v6.13.0...v6.13.1) (2024-09-03) ### Bug Fixes * revert companion pattern except constants ([#1193](#1193)) ([ebf9f35](ebf9f35))
🎉 This issue has been resolved in version 6.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Motivation and Resolution
Use companion pattern instead because of the type safety except constants to avoid build issues.
Tested by linking the newly built version within Starknet Wallet Account (linked it locally, also tested packed variant of project).
Next steps for new PR’s:
constants.ts
works properly without using enumsRPC version (if applicable)
Usage related changes
n.a
Development related changes
n.a
Checklist: