Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FeltVisitor expecting message #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FabijanC
Copy link

Pull Request type

  • Bugfix

What is the current behavior?

Wrong message used in the expecting method of FeltVisitor, not following the documentation:

The message should complete the sentence "This Visitor expects to receive ...", for example the message could be "an integer between 0 and 64". The message should not be capitalized and should not end with a period.

Issue #81 makes several related reports, some of which have their root in the code imported from lambdaworks. If those parts of the issue are not going to be addressed in this repository, then the issue can be labeled as resolvable by this PR.

What is the new behavior?

The fixed method now uses the expected message structure.

Does this introduce a breaking change?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants