Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

chore: move compilation logic to FeatureContracts enum #1869

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented May 6, 2024

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 6, 2024
@dorimedini-starkware dorimedini-starkware force-pushed the dori/move-compilation-logic-to-feature-contracts-enum branch from ab36a89 to 7150c66 Compare May 6, 2024 17:55
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 77.61%. Comparing base (4bdfda2) to head (72f5494).

Files Patch % Lines
crates/blockifier/src/test_utils/contracts.rs 33.33% 24 Missing ⚠️
crates/blockifier/src/test_utils/cairo_compile.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
- Coverage   77.93%   77.61%   -0.33%     
==========================================
  Files          61       62       +1     
  Lines        8766     8813      +47     
  Branches     8766     8813      +47     
==========================================
+ Hits         6832     6840       +8     
- Misses       1494     1533      +39     
  Partials      440      440              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @OriStarkware and @Yoni-Starkware)


crates/blockifier/src/test_utils/cairo_compile.rs line 10 at r1 (raw file):

    }
    if !debug_info {
        command.args([&path, "--no_debug_info"]);

blocking self: path arg needs to be added regardless of debug info flag

Code quote:

command.args([&path, "--no_debug_info"]);

@dorimedini-starkware dorimedini-starkware changed the base branch from dori/feature-contracts-wip to main May 21, 2024 08:15
@dorimedini-starkware dorimedini-starkware force-pushed the dori/move-compilation-logic-to-feature-contracts-enum branch from 7fba16f to 72f5494 Compare May 21, 2024 08:18
gswirski pushed a commit to reilabs/blockifier that referenced this pull request Jun 26, 2024
* fix: ensure correct subdmodule path and rev for solidity forge-std

* fix: adjust messaging guide for L1-L2 messaging

* fix: adjust messaging guide for L1-L3 messaging
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants