This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 107
chore: move compilation logic to FeatureContracts enum #1869
Open
dorimedini-starkware
wants to merge
1
commit into
main
Choose a base branch
from
dori/move-compilation-logic-to-feature-contracts-enum
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: move compilation logic to FeatureContracts enum #1869
dorimedini-starkware
wants to merge
1
commit into
main
from
dori/move-compilation-logic-to-feature-contracts-enum
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dorimedini-starkware
force-pushed
the
dori/move-compilation-logic-to-feature-contracts-enum
branch
from
May 6, 2024 17:55
ab36a89
to
7150c66
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1869 +/- ##
==========================================
- Coverage 77.93% 77.61% -0.33%
==========================================
Files 61 62 +1
Lines 8766 8813 +47
Branches 8766 8813 +47
==========================================
+ Hits 6832 6840 +8
- Misses 1494 1533 +39
Partials 440 440 ☔ View full report in Codecov by Sentry. |
dorimedini-starkware
force-pushed
the
dori/feature-contracts-wip
branch
from
May 7, 2024 10:16
fdc6378
to
3c6d246
Compare
dorimedini-starkware
force-pushed
the
dori/move-compilation-logic-to-feature-contracts-enum
branch
from
May 7, 2024 10:17
7150c66
to
7fba16f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @OriStarkware and @Yoni-Starkware)
crates/blockifier/src/test_utils/cairo_compile.rs
line 10 at r1 (raw file):
} if !debug_info { command.args([&path, "--no_debug_info"]);
blocking self: path
arg needs to be added regardless of debug info flag
Code quote:
command.args([&path, "--no_debug_info"]);
dorimedini-starkware
force-pushed
the
dori/feature-contracts-wip
branch
from
May 21, 2024 07:41
3c6d246
to
9829f40
Compare
dorimedini-starkware
changed the base branch from
dori/feature-contracts-wip
to
main
May 21, 2024 08:15
Signed-off-by: Dori Medini <[email protected]>
dorimedini-starkware
force-pushed
the
dori/move-compilation-logic-to-feature-contracts-enum
branch
from
May 21, 2024 08:18
7fba16f
to
72f5494
Compare
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
* fix: ensure correct subdmodule path and rev for solidity forge-std * fix: adjust messaging guide for L1-L2 messaging * fix: adjust messaging guide for L1-L3 messaging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is