This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 107
chore: fetch Cairo1 compiler version from Cargo.toml #1872
Open
dorimedini-starkware
wants to merge
3
commits into
dori/move-compilation-logic-to-feature-contracts-enum
Choose a base branch
from
dori/fetch-compiler-version
base: dori/move-compilation-logic-to-feature-contracts-enum
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: fetch Cairo1 compiler version from Cargo.toml #1872
dorimedini-starkware
wants to merge
3
commits into
dori/move-compilation-logic-to-feature-contracts-enum
from
dori/fetch-compiler-version
+238
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dorimedini-starkware
force-pushed
the
dori/fetch-compiler-version
branch
from
May 6, 2024 18:13
b9226c1
to
e353e2a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dori/move-compilation-logic-to-feature-contracts-enum #1872 +/- ##
=========================================================================================
- Coverage 77.32% 77.24% -0.09%
=========================================================================================
Files 61 61
Lines 8662 8671 +9
Branches 8662 8671 +9
=========================================================================================
Hits 6698 6698
- Misses 1525 1534 +9
Partials 439 439 ☔ View full report in Codecov by Sentry. |
dorimedini-starkware
force-pushed
the
dori/fetch-compiler-version
branch
2 times, most recently
from
May 6, 2024 18:18
8ccd959
to
76dcca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/blockifier/src/test_utils/cairo_compile.rs
line 50 at r2 (raw file):
DependencyValue::String(version) | DependencyValue::Object { version } => version.clone(), } }
tested manually:
#[rstest]
fn test_manually() {
assert_eq!("2.6.0", cairo1_compiler_version());
}
Code quote:
pub fn cairo1_compiler_version() -> String {
let cargo_toml: CargoToml = toml::from_str(include_str!("../../../../Cargo.toml")).unwrap();
match cargo_toml.workspace.dependencies.cairo_lang_casm {
DependencyValue::String(version) | DependencyValue::Object { version } => version.clone(),
}
}
Signed-off-by: Dori Medini <[email protected]>
Signed-off-by: Dori Medini <[email protected]>
dorimedini-starkware
force-pushed
the
dori/move-compilation-logic-to-feature-contracts-enum
branch
from
May 7, 2024 10:17
7150c66
to
7fba16f
Compare
Signed-off-by: Dori Medini <[email protected]>
dorimedini-starkware
force-pushed
the
dori/fetch-compiler-version
branch
from
May 7, 2024 10:17
76dcca0
to
aed63a4
Compare
dorimedini-starkware
force-pushed
the
dori/move-compilation-logic-to-feature-contracts-enum
branch
from
May 21, 2024 08:18
7fba16f
to
72f5494
Compare
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
Co-authored-by: glihm <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is