-
Notifications
You must be signed in to change notification settings - Fork 107
fix: state error unavailable contract address format #2078
base: main-v0.13.2
Are you sure you want to change the base?
Conversation
f66298a
to
9fa5685
Compare
2b23e50
to
2b421bb
Compare
816120e
to
af2c022
Compare
2b421bb
to
5c29d85
Compare
af2c022
to
e14b18b
Compare
5c29d85
to
b714a3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware)
.gitignore
line 12 at r1 (raw file):
tmp_venv/* .spr.yml
hmmm... shame to ignore this, there are settings here that depend on the repo, not the user. right? for merge queue, for example?
is it possible to "split" .spr.yml to repo/user settings?
or maybe possible to use environment variables in .spr.yml, so only each user's .bashrc
needs to add metadata for the specific user in environment variables, and then you can commit .spr.yml?
out of scope, please add a TODO here in a comment to investigate this
Code quote:
.spr.yml
crates/blockifier/src/state/error_format_test.rs
line 18 at r1 (raw file):
#[test] fn test_error_unavailable_contract_address_format() { let error = StateError::UnavailableContractAddress(ContractAddress::from(10_u128));
(non-blocking FYI: this should work too)
Suggestion:
let error = StateError::UnavailableContractAddress(10_u128.into());
crates/blockifier/src/state/errors.rs
line 22 at r1 (raw file):
#[error(transparent)] ProgramError(#[from] ProgramError), #[error("Requested {:#064x} is unavailable for deployment.",***.0)]
no auto-formatting in macros
Suggestion:
, ***.0)]
e14b18b
to
ab811f3
Compare
b714a3d
to
d57f8db
Compare
ab811f3
to
1802ea2
Compare
commit-id:def3bf73
1802ea2
to
f9dd71b
Compare
This change is